Add TODOs

[khatus.git] / x5 / khatus.c

diff --git a/x5/khatus.c b/x5/khatus.c
index faef5b1..5f283db 100644 (file)
--- a/x5/khatus.c
+++ b/x5/khatus.c
@@ -19,6 +19,7 @@
 
 char *argv0;
 
+/* TODO: Convert file list to file array. */
 typedef struct File File;
 struct File {
        char   *name;
@@ -237,28 +238,21 @@ opts_parse(Config *cfg, int argc, char *argv[], int i)
 void
 read_one(File *f, char *buf)
 {
-       ssize_t n;
+       ssize_t current;
+       ssize_t total;
        char *b;
+       char c;
 
+       current = 0;
+       total = 0;
+       c = '\0';
        b = buf + f->pos;
        memset(b, ' ', f->width);
-       /* TODO: Read upto \n or width */
-       while ((n = read(f->fd, b, f->width)) > 0) {
-               b += n;
-               debug("read %zd from %s\n", n, f->name);
-       }
-
-       if (n > -1) {
-               if (*(b - 1) == '\n')
-                       *(b - 1) = ' ';
-       } else {
-               error(
-                       "Failed to read: \"%s\". Error: %s\n",
-                       f->name,
-                       strerror(errno)
-               );
-       }
-
+       while ((current = read(f->fd, &c, 1)) && c != '\n' && c != '\0' && total++ < f->width)
+               *b++ = c;
+       if (current == -1)
+               error("Failed to read: \"%s\". Error: %s\n", f->name, strerror(errno));
+       /* TODO Record timestamp read */
        close(f->fd);
        f->fd = -1;
 }
@@ -348,6 +342,9 @@ main(int argc, char *argv[])
        printf("%s\n", buf);
        /* TODO: nanosleep and nano time diff */
        for (;;) {
+               /* TODO: Check TTL and maybe blank-out */
+               /* TODO: How to trigger TTL check? On select? Alarm signal? */
+               /* TODO: Option to set X root window title or print */
                read_all(cfg, buf);
                printf("%s\n", buf);
        }