#include "khatus_lib_log.h"
#include "khatus_lib_time.h"
-#define usage(...) {print_usage(); fprintf(stderr, "Error:\n " __VA_ARGS__); exit(EXIT_FAILURE);}
+#define usage(...) { \
+ print_usage(); \
+ fprintf(stderr, "Error:\n " __VA_ARGS__); \
+ exit(EXIT_FAILURE); \
+}
#define ERRMSG "ERROR"
static const char errmsg[] = ERRMSG;
int fifo_count;
int total_width;
int output_to_x_root_window;
-} defaults = {
- .interval = 1.0,
- .separator = "|",
- .fifos = NULL,
- .fifo_count = 0,
- .total_width = 0,
- .output_to_x_root_window = 0,
};
enum read_status {
);
}
-void opts_parse_any(Config *, int, char *[], int); /* For mutually-recursive calls. */
+/* For mutually-recursive calls. */
+void opts_parse_any(Config *, int, char *[], int);
void
parse_opts_opt_i(Config *cfg, int argc, char *argv[], int i)
usage("Option -l parameter is invalid: \"%s\"\n", param);
log_level = atoi(param);
if (log_level > Debug)
- usage("Option -l value (%d) exceeds maximum (%d)\n", log_level, Debug);
+ usage(
+ "Option -l value (%d) exceeds maximum (%d)\n",
+ log_level,
+ Debug
+ );
_khatus_lib_log_level = log_level;
opts_parse_any(cfg, argc, argv, i);
}
parse_opts_spec(Config *cfg, int argc, char *argv[], int i)
{
if ((i + 3) > argc)
- usage("[spec] Parameter(s) missing for fifo \"%s\".\n", argv[i]);
+ usage(
+ "[spec] Parameter(s) missing for fifo \"%s\".\n",
+ argv[i]
+ );
char *n = argv[i++];
char *w = argv[i++];
if (f->pos_curr <= f->pos_final)
buf[f->pos_curr++] = c;
/* Drop beyond available range. */
+ /*
+ * TODO Define max after which we stop reading.
+ * To ensure that a rogue large message
+ * doesn't trap us here.
+ */
}
break;
default:
for (Fifo *f = cfg->fifos; f; f = f->next) {
/* TODO: Create the FIFO if it doesn't already exist. */
if (lstat(f->name, &st) < 0) {
- error("Cannot stat \"%s\". Error: %s\n", f->name, strerror(errno));
+ error(
+ "Cannot stat \"%s\". Error: %s\n",
+ f->name,
+ strerror(errno)
+ );
fifo_read_error(f, buf);
continue;
}
debug("%s: already openned. fd: %d\n", f->name, f->fd);
}
if (f->fd == -1) {
- /* TODO: Consider backing off retries for failed fifos. */
+ /* TODO Consider backing off retries for failed fifos */
error("Failed to open \"%s\"\n", f->name);
fifo_read_error(f, buf);
continue;
/* TODO: Reconsider what to do here. */
return;
default:
- error("pselect failed: %d, errno: %d, msg: %s\n",
+ fatal("pselect failed: %d, errno: %d, msg: %s\n",
ready, errno, strerror(errno));
}
}
int
main(int argc, char *argv[])
{
+ Config cfg = {
+ .interval = 1.0,
+ .separator = "|",
+ .fifos = NULL,
+ .fifo_count = 0,
+ .total_width = 0,
+ .output_to_x_root_window = 0,
+ };
+
int width = 0;
int nfifos = 0;
int seplen = 0;
int prefix = 0;
int errors = 0;
char *buf;
- Config cfg0 = defaults;
- Config *cfg = &cfg0;
- Display *display = NULL;
+ Display *d = NULL;
struct stat st;
struct timespec
t0, /* time stamp. before reading fifos */
argv0 = argv[0];
- opts_parse(cfg, argc, argv);
+ opts_parse(&cfg, argc, argv);
debug("argv0 = %s\n", argv0);
- config_print(cfg);
+ config_print(&cfg);
- ti = timespec_of_float(cfg->interval);
+ ti = timespec_of_float(cfg.interval);
- if (cfg->fifos == NULL)
+ if (cfg.fifos == NULL)
usage("No fifo specs were given!\n");
/* 1st pass to check file existence and type */
- for (Fifo *f = cfg->fifos; f; f = f->next) {
+ for (Fifo *f = cfg.fifos; f; f = f->next) {
if (lstat(f->name, &st) < 0) {
- error("Cannot stat \"%s\". Error: %s\n", f->name, strerror(errno));
+ error(
+ "Cannot stat \"%s\". Error: %s\n",
+ f->name,
+ strerror(errno)
+ );
errors++;
continue;
}
}
}
if (errors)
- fatal("Encountered errors with the given file paths. See log.\n");
+ fatal("Encountered errors with given file paths. See log.\n");
- width = cfg->total_width;
- seplen = strlen(cfg->separator);
+ width = cfg.total_width;
+ seplen = strlen(cfg.separator);
/* 2nd pass to make space for separators */
- for (Fifo *f = cfg->fifos; f; f = f->next) {
+ for (Fifo *f = cfg.fifos; f; f = f->next) {
f->pos_init += prefix;
f->pos_final += prefix;
f->pos_curr = f->pos_init;
memset(buf, ' ', width);
buf[width] = '\0';
/* 3rd pass to set the separators */
- for (Fifo *f = cfg->fifos; f; f = f->next) {
+ for (Fifo *f = cfg.fifos; f; f = f->next) {
if (f->pos_init) { /* Skip the first, left-most */
/* Copying only seplen ensures we omit the '\0' byte. */
- strncpy(buf + (f->pos_init - seplen), cfg->separator, seplen);
+ strncpy(
+ buf + (f->pos_init - seplen),
+ cfg.separator,
+ seplen
+ );
}
}
- if (cfg->output_to_x_root_window && !(display = XOpenDisplay(NULL)))
- fatal("XOpenDisplay failed with: %p\n", display);
+ if (cfg.output_to_x_root_window && !(d = XOpenDisplay(NULL)))
+ fatal("XOpenDisplay failed with: %p\n", d);
/* TODO: Handle signals */
for (;;) {
clock_gettime(CLOCK_MONOTONIC, &t0); // FIXME: check errors
- fifo_read_all(cfg, &ti, buf);
- if (cfg->output_to_x_root_window) {
- if (XStoreName(display, DefaultRootWindow(display), buf) < 0)
+ fifo_read_all(&cfg, &ti, buf);
+ if (cfg.output_to_x_root_window) {
+ if (XStoreName(d, DefaultRootWindow(d), buf) < 0)
fatal("XStoreName failed.\n");
- XFlush(display);
+ XFlush(d);
} else {
puts(buf);
fflush(stdout);
}
clock_gettime(CLOCK_MONOTONIC, &t1); // FIXME: check errors
timespecsub(&t1, &t0, &td);
- debug("td {tv_sec = %ld, tv_nsec = %ld}\n", td.tv_sec, td.tv_nsec);
+ debug(
+ "td {tv_sec = %ld, tv_nsec = %ld}\n",
+ td.tv_sec,
+ td.tv_nsec
+ );
if (timespeccmp(&td, &ti, <)) {
/* Pushback on data producers by refusing to read the
* pipe more frequently than the interval.