Explicitly name each version of the output under comparison.

[hope.git] / test / hope_list_SUITE.erl

diff --git a/test/hope_list_SUITE.erl b/test/hope_list_SUITE.erl
index d5ac392..e1f8375 100644 (file)
--- a/test/hope_list_SUITE.erl
+++ b/test/hope_list_SUITE.erl
@@ -10,19 +10,22 @@
 
 %% Test cases
 -export(
-    [ t_unique_preserve_order/1
-    , t_hope_list_specs/1
-    , t_map_rev/1
-    , t_map_slow/1
-    , t_map/1
-    , t_map_3/1
-    , t_map_result/1
+    [ t_auto_hope_list_specs/1
+    , t_auto_map/1
+    , t_auto_map_3/1
+    , t_auto_map_rev/1
+    , t_auto_map_slow/1
+    , t_auto_unique_preserve_order/1
+    , t_manual_map/1
+    , t_manual_map_result/1
+    , t_manual_map_rev/1
+    , t_manual_map_slow/1
     ]).
 
 
 -define(GROUP , hope_list).
 
--define(CHECK(F), true = proper:quickcheck(F())).
+-define(TEST(TestSpec), true = proper:quickcheck(TestSpec)).
 
 -define(type, proper_types).
 
@@ -36,41 +39,32 @@ all() ->
 
 groups() ->
     Tests =
-        [ t_unique_preserve_order
-        , t_hope_list_specs
-        , t_map_rev
-        , t_map_slow
-        , t_map
-        , t_map_3
-        , t_map_result
+        [ t_auto_hope_list_specs
+        , t_auto_map
+        , t_auto_map_3
+        , t_auto_map_rev
+        , t_auto_map_slow
+        , t_auto_unique_preserve_order
+        , t_manual_map
+        , t_manual_map_result
+        , t_manual_map_rev
+        , t_manual_map_slow
         ],
     Properties = [parallel],
     [{?GROUP, Properties, Tests}].
 
-
 %% =============================================================================
-%%  Test cases
+%%  Manual test cases
 %% =============================================================================
 
-t_map_rev(_Cfg) ->
-    ?CHECK(proper_spec_map_rev).
-
-t_map_slow(_Cfg) ->
-    ?CHECK(proper_spec_map_slow).
-
-t_map(_Cfg) ->
-    ?CHECK(proper_spec_map).
-
-t_map_3(_Cfg) ->
-    ?CHECK(proper_spec_map_3).
-
-t_unique_preserve_order(_Cfg) ->
-    ?CHECK(proper_spec_prop_unique_preserve_order).
+t_manual_map(_Cfg) ->
+    F = fun (N) -> N + 1 end,
+    Xs = lists:seq(1, 5010),
+    Ys = lists:map(F, Xs),
+    Ys = hope_list:map(Xs, F),
+    [] = hope_list:map([], F).
 
-t_hope_list_specs(_Cfg) ->
-    [] = proper:check_specs(hope_list).
-
-t_map_result(_Cfg) ->
+t_manual_map_result(_Cfg) ->
     AssertPositive =
         fun (I) when I > 0 -> {ok, I}; (_) -> {error, negative} end,
     AllPositives = lists:seq(1, 5),
@@ -80,37 +74,55 @@ t_map_result(_Cfg) ->
     {error, negative}  = hope_list:map_result(AllNegatives, AssertPositive),
     {error, negative}  = hope_list:map_result(Mixed, AssertPositive).
 
-%% ============================================================================
-%% PropEr test specs
-%% ============================================================================
+t_manual_map_rev(_Cfg) ->
+    F = fun (N) -> N + 1 end,
+    [4, 3, 2] = hope_list:map_rev([1, 2, 3], F),
+    []        = hope_list:map_rev([], F).
 
-proper_spec_map_rev() ->
-    ?FORALL({L, F}, {type_l(), type_f()},
+t_manual_map_slow(_Cfg) ->
+    F = fun (N) -> N + 1 end,
+    [2, 3, 4] = hope_list:map_slow([1, 2, 3], F),
+    []        = hope_list:map_slow([], F).
+
+%% =============================================================================
+%%  Generated test cases
+%% =============================================================================
+
+t_auto_map_rev(_Cfg) ->
+    ?TEST(?FORALL({L, F}, {type_l(), type_f()},
         hope_list:map_rev(L, F) == lists:reverse(lists:map(F, L))
-    ).
+    )).
 
-proper_spec_map_slow() ->
-    ?FORALL({L, F}, {type_l(), type_f()},
+t_auto_map_slow(_Cfg) ->
+    ?TEST(?FORALL({L, F}, {type_l(), type_f()},
         hope_list:map_slow(L, F) == lists:map(F, L)
-    ).
+    )).
 
-proper_spec_map() ->
-    ?FORALL({L, F}, {type_l(), type_f()},
+t_auto_map(_Cfg) ->
+    ?TEST(?FORALL({L, F}, {type_l(), type_f()},
         hope_list:map(L, F) == lists:map(F, L)
-    ).
+    )).
 
-proper_spec_map_3() ->
-    ?FORALL({L, F, N}, {type_l(), type_f(), ?type:non_neg_integer()},
+t_auto_map_3(_Cfg) ->
+    ?TEST(?FORALL({L, F, N}, {type_l(), type_f(), ?type:non_neg_integer()},
         hope_list:map(L, F, N) == lists:map(F, L)
-    ).
+    )).
 
-proper_spec_prop_unique_preserve_order() ->
-    ?FORALL(L, ?type:list(),
+t_auto_unique_preserve_order(_Cfg) ->
+    ?TEST(?FORALL(L, ?type:list(),
     begin
         Duplicates = L -- lists:usort(L),
-        hope_list:unique_preserve_order(L) ==
-            lists:reverse(lists:reverse(L) -- Duplicates)
-    end).
+        UniquesInOrderA = lists:reverse(lists:reverse(L) -- Duplicates),
+        UniquesInOrderB = hope_list:unique_preserve_order(L),
+        UniquesInOrderA == UniquesInOrderB
+    end)).
+
+t_auto_hope_list_specs(_Cfg) ->
+    [] = proper:check_specs(hope_list).
+
+%% ============================================================================
+%% Common types
+%% ============================================================================
 
 type_l() ->
     ?type:list(?type:integer()).