From: Siraaj Khandkar <siraaj@khandkar.net>
Date: Fri, 30 Oct 2020 21:06:42 +0000 (-0400)
Subject: Use local and read-only vars where possible
X-Git-Url: https://git.xandkar.net/?p=khome.git;a=commitdiff_plain;h=1f80896b151cb7c41d4bdbc5c0647b88ba621894

Use local and read-only vars where possible
---

diff --git a/home/lib/login_functions.sh b/home/lib/login_functions.sh
index 29b00ee..4fc413f 100644
--- a/home/lib/login_functions.sh
+++ b/home/lib/login_functions.sh
@@ -267,9 +267,10 @@ gh_fetch_repos() {
 }
 
 gh_clone() {
-    gh_user_type="$1"
-    gh_user_name="$2"
-    gh_dir="${DIR_GITHUB}/${gh_user_name}"
+    local -r gh_user_type="$1"
+    local -r gh_user_name="$2"
+
+    local -r gh_dir="${DIR_GITHUB}/${gh_user_name}"
     mkdir -p "$gh_dir"
     cd "$gh_dir" || kill -INT $$
     gh_fetch_repos "$gh_user_type" "$gh_user_name" \
@@ -317,7 +318,7 @@ EOF
 
 work_log() {
     mkdir -p "$DIR_WORK_LOG"
-    file_work_log_today="${DIR_WORK_LOG}/$(date +%F).md"
+    local -r file_work_log_today="${DIR_WORK_LOG}/$(date +%F).md"
     if [ ! -f "$file_work_log_today" ]
     then
         work_log_template > "$file_work_log_today"
@@ -353,10 +354,12 @@ bt_devs() {
 }
 
 run() {
-    stderr="$(mktemp)"
+    local -r stderr="$(mktemp)"
+
+    local code urgency
+
     $@ 2> >(tee "$stderr")
     code="$?"
-    urgency=''
     case "$code" in
         0) urgency='normal';;
         *) urgency='critical'