From: Siraaj Khandkar <siraaj@khandkar.net>
Date: Thu, 12 Mar 2020 01:13:25 +0000 (-0400)
Subject: Blank-out only the remaining slots
X-Git-Url: https://git.xandkar.net/?p=khatus.git;a=commitdiff_plain;h=7fb02106fc146cdfad92fe5bafad2336c9b166c1

Blank-out only the remaining slots
---

diff --git a/x5/khatus.c b/x5/khatus.c
index 2a026dc..26e491a 100644
--- a/x5/khatus.c
+++ b/x5/khatus.c
@@ -276,14 +276,14 @@ fifo_read_one(Fifo *f, char *buf)
 	total = 0;
 	c = '\0';
 	b = buf + f->pos;
-	/* TODO: Could optimize here and only blank-out the remaining slots. */
-	memset(b, ' ', f->width);
 	while ((current = read(f->fd, &c, 1)) && c != '\n' && c != '\0' && total++ < f->width)
 		*b++ = c;
 	if (current == -1) {
 		error("Failed to read: \"%s\". Error: %s\n", f->name, strerror(errno));
 		fifo_read_error(f, buf);
-	}
+	} else
+		while (total++ < f->width)
+			*b++ = ' ';
 	/* TODO Record timestamp read */
 	close(f->fd);
 	f->fd = -1;