From 8c54ccb832581554a2c272c0f08b4300081d22b5 Mon Sep 17 00:00:00 2001 From: Siraaj Khandkar Date: Wed, 21 Nov 2018 17:17:25 -0500 Subject: [PATCH] Add TODO note for better abstractions --- dups.ml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dups.ml b/dups.ml index 28c2663..c627369 100644 --- a/dups.ml +++ b/dups.ml @@ -256,6 +256,15 @@ let main {input; output; ignore; sample = sample_len} = in Hashtbl.replace tbl group (count + 1, File.Set.add file files) in + (* TODO: Make a nice(r) abstraction to re-assemble pieces in the pipeline: + * + * from input to files_by_size + * from files_by_size to files_by_sample + * from files_by_sample to files_by_digest + * from files_by_digest to output + * + * input |> files_by_size |> files_by_sample |> files_by_digest |> output + *) Stream.iter input ~f:(fun ({File.size; _} as file) -> process files_by_size ~group:size ~file ); -- 2.20.1