From 5681263ff2c3c3336fbc501c31365f452039c394 Mon Sep 17 00:00:00 2001 From: Siraaj Khandkar Date: Thu, 20 Aug 2015 10:52:33 -0400 Subject: [PATCH] Remove superfluous tests. --- src/beam_stats_consumer_statsd.erl | 34 ----------------------- test/beam_stats_consumer_statsd_SUITE.erl | 32 ++------------------- 2 files changed, 3 insertions(+), 63 deletions(-) diff --git a/src/beam_stats_consumer_statsd.erl b/src/beam_stats_consumer_statsd.erl index 97e458d..70ed8dc 100644 --- a/src/beam_stats_consumer_statsd.erl +++ b/src/beam_stats_consumer_statsd.erl @@ -16,15 +16,6 @@ , terminate/1 ]). -%% Tests (to be run by CT): --export( - [ ct_test__beam_stats_to_bins/1 - , ct_test__memory_component_to_statsd_msg/1 - , ct_test__statsd_msg_add_name_prefix/1 - , ct_test__statsd_msg_to_bin/1 - , ct_test__node_id_to_bin/1 - ]). - -type option() :: {consumption_interval , non_neg_integer()} | {dst_host , inet:ip_address() | inet:hostname()} @@ -208,28 +199,3 @@ metric_type_to_bin(gauge) -> node_id_to_bin(NodeID) -> NodeIDBin = atom_to_binary(NodeID, utf8), re:replace(NodeIDBin, "[\@\.]", "_", [global, {return, binary}]). - -%% ============================================================================ -%% Tests -%% ============================================================================ - -ct_test__beam_stats_to_bins(_Cfg) -> - BEAMStats = #beam_stats{node_id = 'node@host.local', memory = [{foo,1}]}, - [<>] = - beam_stats_to_bins(BEAMStats). - -ct_test__memory_component_to_statsd_msg(_Cfg) -> - #statsd_msg{name = <<"foo">>, value = 1, type = gauge} = - memory_component_to_statsd_msg({foo, 1}). - -ct_test__statsd_msg_add_name_prefix(_Cfg) -> - Msg1 = #statsd_msg{name = <<"foo">>, value = 1, type = gauge}, - Msg2 = statsd_msg_add_name_prefix(Msg1, <<"bar">>), - <> = Msg2#statsd_msg.name. - -ct_test__statsd_msg_to_bin(_Cfg) -> - Msg = #statsd_msg{name = <<"foo">>, value = 1, type = gauge}, - <<"foo:1|g\n">> = statsd_msg_to_bin(Msg). - -ct_test__node_id_to_bin(_Cfg) -> - <<"foo_bar_local">> = node_id_to_bin('foo@bar.local'). diff --git a/test/beam_stats_consumer_statsd_SUITE.erl b/test/beam_stats_consumer_statsd_SUITE.erl index 47a00f7..f5fbc0b 100644 --- a/test/beam_stats_consumer_statsd_SUITE.erl +++ b/test/beam_stats_consumer_statsd_SUITE.erl @@ -9,16 +9,10 @@ %% Test cases -export( - [ t_beam_stats_to_bins/1 - , t_memory_component_to_statsd_msg/1 - , t_statsd_msg_add_name_prefix/1 - , t_statsd_msg_to_bin/1 - , t_node_id_to_bin/1 - , t_send/1 + [ t_send/1 ]). --define(statsd_module, beam_stats_consumer_statsd). --define(GROUP, ?statsd_module). +-define(GROUP, beam_stats_consumer_statsd). %% ============================================================================ %% Common Test callbacks @@ -29,12 +23,7 @@ all() -> groups() -> Tests = - [ t_beam_stats_to_bins - , t_memory_component_to_statsd_msg - , t_statsd_msg_add_name_prefix - , t_statsd_msg_to_bin - , t_node_id_to_bin - , t_send + [ t_send ], Properties = [], [{?GROUP, Properties, Tests}]. @@ -43,21 +32,6 @@ groups() -> %% Test cases %% ============================================================================= -t_beam_stats_to_bins(_Cfg) -> - ?statsd_module:ct_test__beam_stats_to_bins(_Cfg). - -t_memory_component_to_statsd_msg(_Cfg) -> - ?statsd_module:ct_test__memory_component_to_statsd_msg(_Cfg). - -t_statsd_msg_add_name_prefix(_Cfg) -> - ?statsd_module:ct_test__statsd_msg_add_name_prefix(_Cfg). - -t_statsd_msg_to_bin(_Cfg) -> - ?statsd_module:ct_test__statsd_msg_to_bin(_Cfg). - -t_node_id_to_bin(_Cfg) -> - ?statsd_module:ct_test__node_id_to_bin(_Cfg). - t_send(_Cfg) -> BEAMStats = #beam_stats { timestamp = {1, 2, 3} -- 2.20.1