From: Siraaj Khandkar <siraaj@khandkar.net>
Date: Wed, 28 Nov 2018 01:26:47 +0000 (-0500)
Subject: Slightly refactor lord's and vassal's loops
X-Git-Url: https://git.xandkar.net/?a=commitdiff_plain;h=df1a915e9a9c3533ce82922ad38bab3884ff3b99;p=dups.git

Slightly refactor lord's and vassal's loops
---

diff --git a/dups.ml b/dups.ml
index b83b4be..e214d25 100644
--- a/dups.ml
+++ b/dups.ml
@@ -285,31 +285,29 @@ end = struct
   let lord t ~njobs ~vassals ~ic ~ocs =
     let active_vassals = ref njobs in
     let results = Queue.create () in
-    let rec dispatch () =
+    let rec loop () =
       match ((Ipc.recv ic) : ('input, 'output) msg_from_vassal) with
       | Exiting i ->
           close_out ocs.(i);
           decr active_vassals;
-          if !active_vassals = 0 then
-            ()
-          else
-            dispatch ()
+          if !active_vassals = 0 then () else loop ()
       | Ready i ->
           Ipc.send ocs.(i) (Job (next t));
-          dispatch ()
+          loop ()
       | Result (i, result) ->
           Queue.add result results;
           Ipc.send ocs.(i) (Job (next t));
-          dispatch ()
+          loop ()
     in
     let rec wait = function
-      | [] -> ()
+      | [] ->
+          ()
       | vassals ->
           let pid, _process_status = Unix.wait () in
           (* TODO: handle process_status *)
           wait (List.filter vassals ~f:(fun p -> p <> pid))
     in
-    dispatch ();
+    loop ();
     close_in ic;
     wait vassals;
     of_queue results
@@ -317,15 +315,16 @@ end = struct
   let vassal i ~f ~vassal_pipe_r ~lord_pipe_w =
     let ic = Unix.in_channel_of_descr vassal_pipe_r in
     let oc = Unix.out_channel_of_descr lord_pipe_w in
-    let rec work msg =
-      Ipc.send oc msg;
+    let rec loop () =
       match (Ipc.recv ic : 'input msg_from_lord) with
       | Job (Some x) ->
-          work (Result (i, (x, f x)))
+          Ipc.send oc (Result (i, (x, f x)));
+          loop ()
       | Job None ->
           Ipc.send oc (Exiting i)
     in
-    work (Ready i);
+    Ipc.send oc (Ready i);
+    loop ();
     close_in ic;
     close_out oc;
     exit 0