From: Siraaj Khandkar <siraaj@khandkar.net>
Date: Sat, 4 Aug 2018 19:51:35 +0000 (-0400)
Subject: Propagate controller errors as alerts
X-Git-Url: https://git.xandkar.net/?a=commitdiff_plain;h=0684c7865d61556e13e587dd8eaae538f3e862be;p=khatus.git

Propagate controller errors as alerts
---

diff --git a/bin/khatus_controller b/bin/khatus_controller
index 60a6b19..c56370e 100755
--- a/bin/khatus_controller
+++ b/bin/khatus_controller
@@ -162,7 +162,7 @@ function set_volume(    mute, left, right) {
     } else if (mute == "yes") {
         db["volume"] = "X"
     } else {
-        error("Unexpected value for 'mute' field: " mute)
+        error("set_volume", "Unexpected value for 'mute' field: " mute)
     }
 }
 
@@ -537,8 +537,11 @@ function debug(location, msg, values,    sep, vals, key, payload) {
     }
 }
 
-function error(msg) {
-    output_msg("ERROR", msg, "/dev/stderr")
+function error(location, msg) {
+    # TODO: Reconsider classifying internal errors as alerts
+    #       Maybe better to keep the error class distinct and provide a
+    #       an optional transformation from error to alert
+    alert_trigger_hi(location, "KhatusControllerError", msg)
 }
 
 function ensure_numeric(n) {