home
/
code
/
beam_stats.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Use module() instead of atom() where applicable
[beam_stats.git]
/
src
/
beam_stats_consumer_statsd.erl
diff --git
a/src/beam_stats_consumer_statsd.erl
b/src/beam_stats_consumer_statsd.erl
index
fe8299c
..
70ed8dc
100644
(file)
--- a/
src/beam_stats_consumer_statsd.erl
+++ b/
src/beam_stats_consumer_statsd.erl
@@
-1,6
+1,7
@@
-module(beam_stats_consumer_statsd).
-include("include/beam_stats.hrl").
-module(beam_stats_consumer_statsd).
-include("include/beam_stats.hrl").
+-include("beam_stats_logging.hrl").
-behaviour(beam_stats_consumer).
-behaviour(beam_stats_consumer).
@@
-8,6
+9,7
@@
[ option/0
]).
[ option/0
]).
+%% Consumer interface
-export(
[ init/1
, consume/2
-export(
[ init/1
, consume/2
@@
-15,7
+17,7
@@
]).
-type option() ::
]).
-type option() ::
- {consumption_interval ,
erlang:time
()}
+ {consumption_interval ,
non_neg_integer
()}
| {dst_host , inet:ip_address() | inet:hostname()}
| {dst_port , inet:port_number()}
| {src_port , inet:port_number()}
| {dst_host , inet:ip_address() | inet:hostname()}
| {dst_port , inet:port_number()}
| {src_port , inet:port_number()}
@@
-55,7
+57,7
@@
%% ============================================================================
-spec init([option()]) ->
%% ============================================================================
-spec init([option()]) ->
- {
erlang:time
(), state()}.
+ {
non_neg_integer
(), state()}.
init(Options) ->
ConsumptionInterval = hope_kv_list:get(Options, consumption_interval, 60000),
DstHost = hope_kv_list:get(Options, dst_host, ?DEFAULT_DST_HOST),
init(Options) ->
ConsumptionInterval = hope_kv_list:get(Options, consumption_interval, 60000),
DstHost = hope_kv_list:get(Options, dst_host, ?DEFAULT_DST_HOST),
@@
-89,7
+91,7
@@
terminate(#state{sock=SockOpt}) ->
-spec try_to_send(state(), binary()) ->
state().
try_to_send(#state{sock=none}=State, _) ->
-spec try_to_send(state(), binary()) ->
state().
try_to_send(#state{sock=none}=State, _) ->
-
io:format("error: socket closed~n
"),
+
?log_error("Sending failed. No socket in state.
"),
% TODO: Maybe schedule retry?
State;
try_to_send(
% TODO: Maybe schedule retry?
State;
try_to_send(
@@
-104,7
+106,10
@@
try_to_send(
of ok ->
State
; {error, _}=Error ->
of ok ->
State
; {error, _}=Error ->
- io:format("error: gen_udp:send/4 failed: ~p~n", [Error]),
+ ?log_error(
+ "gen_udp:send(~p, ~p, ~p, ~p) -> ~p",
+ [Sock, DstHost, DstPort, Error]
+ ),
% TODO: Do something with unsent messages?
ok = gen_udp:close(Sock),
State#state{sock=none}
% TODO: Do something with unsent messages?
ok = gen_udp:close(Sock),
State#state{sock=none}
@@
-119,7
+124,7
@@
try_to_connect_if_no_socket(#state{sock=none, src_port=SrcPort}=State) ->
of {ok, Sock} ->
State#state{sock = {some, Sock}}
; {error, _}=Error ->
of {ok, Sock} ->
State#state{sock = {some, Sock}}
; {error, _}=Error ->
-
io:format("error: gen_udp:open/1 failed: ~p~n", [
Error]),
+
?log_error("gen_udp:open(~p) -> ~p", [SrcPort,
Error]),
State#state{sock = none}
end.
State#state{sock = none}
end.
This page took
0.02696 seconds
and
4
git commands to generate.